Headline
CVE-2022-39270: SECURITY: Render TOC items as plain text (#44) · discourse/DiscoTOC@f80c215
DiscoTOC is a Discourse theme component that generates a table of contents for topics. Users that can create topics in TOC-enabled categories (and have sufficient trust level - configured in component’s settings) are able to inject arbitrary HTML on that topic’s page. The issue has been fixed on the main branch. Admins can update the theme component through the admin UI (Customize -> Themes -> Components -> DiscoTOC -> Check for Updates). Alternatively, admins can temporarily disable the DiscoTOC theme component.
@@ -122,3 +122,31 @@ acceptance("DiscoTOC - with categories", function (needs) {
assert.ok(exists(“.d-toc-wrapper #d-toc”));
});
});
acceptance("DiscoTOC - non-text headings", function (needs) {
needs.pretender((server, helper) => {
const topicResponse = cloneJSON(topicFixtures[“/t/280/1.json”]);
topicResponse.post_stream.posts[0].cooked = `
<h3 id="toc-h3-span" data-d-toc="toc-h3-span" class="d-toc-post-heading">
<a name="span-4" class="anchor" href="#span-4"></a><span style="color: red">what about this</span></h3>
</h3>
<p>test</p>
${TOC_MARKUP}
`;
server.get("/t/280.json", () => helper.response(topicResponse));
server.get("/t/280/:post_number.json", () =>
helper.response(topicResponse)
);
});
test("renders the TOC items as plain text", async function (assert) {
await visit(“/t/internationalization-localization/280”);
const item = query(`#d-toc [data-d-toc="toc-h3-span"]`);
assert.strictEqual(
item.innerHTML.trim(),
`<span style="color: red">what about this</span>`
);
});
});